Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SELF-217: Update Alert and Badge Styles #462

Merged
merged 1 commit into from
Mar 20, 2024
Merged

SELF-217: Update Alert and Badge Styles #462

merged 1 commit into from
Mar 20, 2024

Conversation

NateWaldschmidt
Copy link
Contributor

@NateWaldschmidt NateWaldschmidt commented Mar 19, 2024 •
edited
Loading

JIRA

Description

  • Changes the styles of Alert component
  • Updates Badge component to utilize Composition with TS

Screenshots

  • Before
    image
    image

  • After
    image
    image

Reviewer Checklist

This section is to be filled out by reviewers

Testing

  • This code was tested by somebody other than the developer. Do not merge until this has been done.

@NateWaldschmidt NateWaldschmidt mentioned this pull request Mar 19, 2024
Closed
1 task
@guardrails GuardRails
Copy link

guardrails bot commented Mar 19, 2024 •
edited
Loading

⚠️ We detected 7 security issues in this pull request:

Vulnerable Libraries (7)
Severity Details
Critical pkg:npm/[email protected] (t) upgrade to: > 8.2.5
Medium pkg:npm/[email protected] (t) upgrade to: 8.4.31
Medium pkg:npm/[email protected] (t) upgrade to: > 8.7.1
Critical pkg:npm/[email protected] (t) upgrade to: > 10.3.1
Medium pkg:npm/[email protected] (t) upgrade to: > 8.19.0
High pkg:npm/[email protected] (t) upgrade to: > 3.1.6
Critical pkg:npm/[email protected] (t) upgrade to: > 16.8.3

More info on how to fix Vulnerable Libraries in JavaScript.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@NateWaldschmidt NateWaldschmidt force-pushed the SELF-217/update-alert-badge-styles branch from 919b7df to 5c946d7 Compare March 19, 2024 17:49
@aws-amplify-us-west-2 AWS Amplify (us-west-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-462.d11k469e311m4w.amplifyapp.com

@NateWaldschmidt NateWaldschmidt force-pushed the SELF-217/update-alert-badge-styles branch from 5c946d7 to d99c6bc Compare March 19, 2024 17:51
@NateWaldschmidt NateWaldschmidt marked this pull request as ready for review March 19, 2024 18:36
@NateWaldschmidt NateWaldschmidt requested a review from a team as a code owner March 19, 2024 18:36
@NateWaldschmidt NateWaldschmidt marked this pull request as draft March 19, 2024 18:46
@NateWaldschmidt NateWaldschmidt force-pushed the SELF-217/update-alert-badge-styles branch 2 times, most recently from af1e9d5 to bfefcb7 Compare March 19, 2024 18:56
@NateWaldschmidt NateWaldschmidt marked this pull request as ready for review March 19, 2024 19:44
@NateWaldschmidt NateWaldschmidt force-pushed the SELF-217/update-alert-badge-styles branch from bfefcb7 to 3a80d86 Compare March 20, 2024 20:15
@NateWaldschmidt NateWaldschmidt merged commit 8bdaae0 into main Mar 20, 2024
4 of 5 checks passed
@NateWaldschmidt NateWaldschmidt deleted the SELF-217/update-alert-badge-styles branch March 20, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthpant92 siddharthpant92 siddharthpant92 approved these changes

@kencrim kencrim kencrim approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NateWaldschmidt @siddharthpant92 @kencrim